ci: build docker image with travis ci #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
travis-docker-build
branch
from
5798a7c to
2d0594e
Compare
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
changed the title
tisonkun
requested review from
PragmaTwice and
git-hulk
and removed request for
PragmaTwice
|
Travis CI uses 21 minutes to finish the task and I think we can run it every PR, while it's not required. It seems GitHub Actions may support ARM64 in this year (since Azure supported ARM64 arch in April). We can review this topic then but we can also find a way for now like migrate to travis :) See also actions/runner-images#2552 |
2 tasks
git-hulk
approved these changes
Jul 11, 2022
PragmaTwice
approved these changes
Jul 11, 2022
|
Thanks for your reviews! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #718.