Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fpm packaging to x.py #752

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Jul 24, 2022

  • add fpm packaging subcommand ./x.py package fpm
  • add type annotations for all functions
  • add --cmake-path to ./x.py build
  • remove release workflow and package.sh

@git-hulk
Copy link
Member

@PragmaTwice This PR looks good to me and it becomes cleaner that we replace most scripts with x.py, but I'm wondering how we release those binaries after this PR.

@PragmaTwice
Copy link
Member Author

I tried to fix the release workflow and upload packages automatically to a draft release in #751.

@tisonkun suggested that we can directly remove the release workflow and move packaging scripts to x.py.

I do not know whether the release vote process and the release workflow are compatible, maybe we can have a discussion.

@git-hulk
Copy link
Member

Thanks @PragmaTwice, sorry that I didn't have a look at the background.

@xiaobiaozhao
Copy link
Contributor

I think rename x.py to build.py is better filename for user.

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jul 26, 2022

I think rename x.py to build.py is better filename for user.

Hi @xiaobiaozhao, this script is versatile for not just build, for example it can execute code inspection tools, package source code, generate rpm packages, etc. (and more and more features are being added) So naming it build.py may not express this meaning well, you can refer to #725 for details.

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jul 26, 2022

Hi @tisonkun, could you take a look at this PR while free?

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants