-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fpm packaging to x.py #752
Conversation
@PragmaTwice This PR looks good to me and it becomes cleaner that we replace most scripts with |
I tried to fix the release workflow and upload packages automatically to a draft release in #751. @tisonkun suggested that we can directly remove the release workflow and move packaging scripts to x.py. I do not know whether the release vote process and the release workflow are compatible, maybe we can have a discussion. |
Thanks @PragmaTwice, sorry that I didn't have a look at the background. |
I think rename x.py to build.py is better filename for user. |
Hi @xiaobiaozhao, this script is versatile for not just build, for example it can execute code inspection tools, package source code, generate rpm packages, etc. (and more and more features are being added) So naming it |
Hi @tisonkun, could you take a look at this PR while free? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
./x.py package fpm
--cmake-path
to./x.py build
package.sh