Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidden to add ns __namespace #772

Merged
merged 4 commits into from
Aug 7, 2022
Merged

Conversation

mathspanda
Copy link
Contributor

Fix issue #770

  1. Forbidden to create namespace "__namespace"
  2. Add default namespace "__namespace" into the results of "namespace get *"

src/config.cc Outdated Show resolved Hide resolved
tests/cppunit/config_test.cc Outdated Show resolved Hide resolved
tests/cppunit/config_test.cc Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

git-hulk commented Aug 5, 2022

@mathspanda Thanks for finding out and solving this issue, left a few suggestions. You can commit them if look good to you.

src/config.cc Outdated Show resolved Hide resolved
tests/cppunit/config_test.cc Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

git-hulk commented Aug 7, 2022

Thanks all, merging...

@git-hulk git-hulk merged commit add1a78 into apache:unstable Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants