Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newly designed ParseInt #787

Merged
merged 9 commits into from
Aug 27, 2022
Merged

Add newly designed ParseInt #787

merged 9 commits into from
Aug 27, 2022

Conversation

PragmaTwice
Copy link
Member

It is the first (small) step to construct the new command parsing module.

  • add TryParseInt<T> and ParseInt<T> and unit tests
  • use union in StatusOr since it is more readable and no strict aliasing issue

caipengbo
caipengbo reviewed Aug 23, 2022
View reviewed changes
src/parse_util.h Outdated Show resolved Hide resolved
src/parse_util.h Show resolved Hide resolved
tisonkun
tisonkun reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link this PR to the master issue? And is there a description about "the new command parsing module"?

@PragmaTwice
Copy link
Member Author

Could you link this PR to the master issue? And is there a description about "the new command parsing module"?

Hi @tisonkun , there is an old issue #598 to describe it but maybe a little out-dated, and I will create a new issue.

@PragmaTwice PragmaTwice mentioned this pull request Aug 27, 2022
Closed
2 tasks
@PragmaTwice
Copy link
Member Author

Thanks all! Merging...

@PragmaTwice PragmaTwice merged commit e4ae784 into apache:unstable Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@w4096 w4096 w4096 left review comments

@fuzhe1989 fuzhe1989 fuzhe1989 left review comments

@caipengbo caipengbo caipengbo approved these changes

@git-hulk git-hulk git-hulk approved these changes

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PragmaTwice @fuzhe1989 @git-hulk @w4096 @tisonkun @caipengbo