Fix successor commands won't be processed before receiving new read event #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead event Currently, we will stop processing commmands when running into block command like BRPOP/BLPOP and there may have remain commands in connection, but the connection continue handling those commands since the read event was triggered.
git-hulk
changed the title
git-hulk
requested review from
tisonkun,
caipengbo,
PragmaTwice and
ShooterIT
caipengbo
approved these changes
Sep 9, 2022
tisonkun
approved these changes
Sep 9, 2022
|
Thanks all, merging... |
suica
pushed a commit
to suica/incubator-kvrocks
that referenced
this pull request
Sep 11, 2022
…ead event (apache#839) Currently, we will stop processing commands when running into block commands like BRPOP/BLPOP and there remained commands in the connection, but the connection continues handling those commands since the read event was triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we will stop processing commands when running into block commands
like BRPOP/BLPOP and there remained commands in the connection, but the connection
continues handling those commands since the read event was triggered.
This closes #831