Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6476] Fix incomplete app events deserialization in SHS #6479

Closed
wants to merge 3 commits into from

Conversation

felixzh2020
Copy link
Contributor

@felixzh2020 felixzh2020 commented Jun 18, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6476 : spark historyserver -> Show incomplete applications -> kyuubi query engine ui error(java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long).

The reason:
it's related to FasterXML/jackson-module-scala#62

Describe Your Solution 🔧

add @JsonDeserialize(contentAs = classOf[java.lang.Long]) annotation

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix. Please fix the pr title and complete checklist.

@felixzh2020
Copy link
Contributor Author

"fix the pr title" is finished.
Failed checks seems unrelated to the content I modified. Is there a tool similar to flink project "@flinkbot run azure" available?
May be rerun check.

@wForget
Copy link
Member

wForget commented Jun 20, 2024

"fix the pr title" is finished. Failed checks seems unrelated to the content I modified. Is there a tool similar to flink project "@flinkbot run azure" available? May be rerun check.

Never mind, that's an unrelated failure.

@pan3793 pan3793 changed the title [KYUUBI apache#6476] spark historyserver Show incomplete applications… [KYUUBI #6476] Fix deserialization incomplete applications event in SHS Jun 20, 2024
@pan3793 pan3793 changed the title [KYUUBI #6476] Fix deserialization incomplete applications event in SHS [KYUUBI #6476] Fix incomplete app events deserialization in SHS Jun 20, 2024
@pan3793 pan3793 closed this in c6f2ca2 Jun 20, 2024
pan3793 pushed a commit that referenced this pull request Jun 20, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes #6476 : spark historyserver -> Show incomplete applications -> kyuubi query engine ui error(java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long).

The reason:
it's related to FasterXML/jackson-module-scala#62

## Describe Your Solution 🔧

add JsonDeserialize(contentAs = classOf[java.lang.Long]) annotation

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6479 from felixzh2020/issues/6476.

Closes #6476

034bfe5 [felixzh] [KYUUBI #6476] spark historyserver Show incomplete applications kyuubi query engine ui error
b7b0db2 [felixzh] [KYUUBI #6476] spark historyserver Show incomplete applications kyuubi query engine ui error
a66163a [felixzh] [KYUUBI #6476] spark historyserver Show incomplete applications kyuubi query engine ui error

Authored-by: felixzh <felixzh2020@126.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit c6f2ca2)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793 pan3793 added this to the v1.9.2 milestone Jun 20, 2024
@pan3793
Copy link
Member

pan3793 commented Jun 20, 2024

Thanks, merged to master/1.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] spark historyserver Show incomplete applications kyuubi query engine ui error
3 participants