Add new CI job which builds the release artifact, remove MANIFEST.in #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #2024 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 353 353
Lines 81650 81650
Branches 8627 8627
=======================================
Hits 68068 68068
Misses 10760 10760
Partials 2822 2822 |
Kami
force-pushed
the
build_release_artifact_ci_job
branch
5 times, most recently
from
f165cde
to
0b1830a
Compare
Kami
changed the title
Kami
force-pushed
the
build_release_artifact_ci_job
branch
4 times, most recently
from
7a8797e
to
48fb638
Compare
verifies it works (unpacks the tarball, runs tests). Also remove MANIFEST.in in favor or include rules declared in pyproject.toml.
Kami
force-pushed
the
build_release_artifact_ci_job
branch
from
48fb638
to
bf92dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new GHA job as part of the CI workflow which builds the release artifacts and verifies it.
As part of the verification step, we run the following check:
In addition to the CI changes, I fixed and improved
pyproject.tomlfile and removedMANIFEST.inin favor of inclusion directives defined directly in thepyproject.tomlfile.This was done for future proofing reasons and because I noticed that the behavior with
MANIFEST.infile is not consistent in different environments aka builds are not fully reproducible (e.g. on CI, the contents of the tarball was different than contents of the tarball created locally).