Port log4j-1.2-api changes from 2.x
#2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
approved these changes
Jan 15, 2024
ppkarwasz
force-pushed
the
sync-1.2-api
branch
from
e710d4e to
ad89ebe
Compare
The `Category` class constructor should not use the static method `LogManager.getLoggerRepository()` to find the `LoggerRepository` that created it. The value should be injected.
This fixes Spotbugs alerts up to rank 9 (the "scary" category). Most are false positives or problems in the tests. The `LocationInfo` fix in `log4j-1.2-api` prevents an NPE though.
Adds a builder for Apache Extras' `RollingFileAppender`.
…vior (apache#924) The current `LevelRangeFilterBuilder` does not take into account the inversion of the level scale between Log4j 1 and Log4j 2: a minimal Log4j 1 level corresponds to a maximal Log4j 2 level and vice versa.
This ports the changes to the `log4j-1.2-api` module that never made it to `main`. Part of apache#2163.
ppkarwasz
force-pushed
the
sync-1.2-api
branch
from
ad89ebe to
c71bdf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports several changes to the
log4j-1.2-apimodule that are present in2.x, but were never ported tomain.