Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j-layout-jackson and log4j-layout-jackson-xml #2198

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

vy
Copy link
Member

@vy vy commented Jan 16, 2024

Removes XmlLayout (i.e., log4j-layout-jackson-xml) and log4j-layout-jackson, since it is not used anymore.

Review kit

Ignore the changes in log4j-layout-jackson and log4j-layout-jackson-xml folders, since these folders are simply deleted. Focus on the rest instead.

@vy vy added the layouts Affects one or more Layout plugins label Jan 16, 2024
@vy vy added this to the 3.0.0 milestone Jan 16, 2024
@vy vy requested a review from ppkarwasz January 16, 2024 08:34
@vy vy self-assigned this Jan 16, 2024
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @garydgregory approved, it is fine with me.

@vy vy merged commit 18cf748 into main Jan 16, 2024
4 of 6 checks passed
@vy vy deleted the main-remove-XmlLayout branch January 16, 2024 08:42
vy added a commit that referenced this pull request Jan 29, 2024
@ppkarwasz ppkarwasz modified the milestones: 3.0.0, 3.0.0-beta2 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layouts Affects one or more Layout plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants