Skip to content

Commit

Permalink
Remove AppenderArray
Browse files Browse the repository at this point in the history
  • Loading branch information
tmct authored Jan 30, 2025
1 parent 11400a1 commit 725c296
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions src/log4net/Util/AppenderAttachedImpl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ public int AppendLoopOnAppenders(LoggingEvent loggingEvent)
return 0;
}

_appenderArray ??= _appenderList.ToArray();

foreach (IAppender appender in _appenderArray)
foreach (IAppender appender in _appenderList.ToArray())
{
try
{
Expand Down Expand Up @@ -116,9 +114,7 @@ public int AppendLoopOnAppenders(LoggingEvent[] loggingEvents)
return 0;
}

_appenderArray ??= _appenderList.ToArray();

foreach (IAppender appender in _appenderArray)
foreach (IAppender appender in _appenderList.ToArray())
{
try
{
Expand Down Expand Up @@ -173,7 +169,6 @@ private static void CallAppend(IAppender appender, LoggingEvent[] loggingEvents)
public void AddAppender(IAppender appender)
{
appender.EnsureNotNull();
_appenderArray = null;
_appenderList ??= new(1);
if (!_appenderList.Contains(appender))
{
Expand Down Expand Up @@ -258,7 +253,6 @@ public void RemoveAllAppenders()
}
}
_appenderList = null;
_appenderArray = null;
}
}

Expand All @@ -283,7 +277,6 @@ public void RemoveAllAppenders()
{
_appenderList = null;
}
_appenderArray = null;
}
return appender;
}
Expand All @@ -307,11 +300,6 @@ public void RemoveAllAppenders()
/// </summary>
private AppenderCollection? _appenderList;

/// <summary>
/// Array of appenders, used to cache the appenderList
/// </summary>
private IAppender[]? _appenderArray;

/// <summary>
/// The fully qualified type of the AppenderAttachedImpl class.
/// </summary>
Expand Down

0 comments on commit 725c296

Please sign in to comment.