-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate site infrastructure to Antora #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since all this PR does is modifying Github Actions can you stage the website after merging this PR to confirm that it works as required? |
I will do that in my follow up PR, where I will implement automatic website publication. 😉 |
apache/logging-log4j2#2427 migrated Log4j 2 to Antora. apache/logging-log4j2#2443 cloned this work for Log4j 3. This PR clones the very same work to
logging-parent
to streamline it for all projects extending from it. A short summary of deliverables are shared below.Deliverables
pre-site
phase and outputs totarget/generated-site
instead. That is, compiledsrc/changelog
will not be dumped tosrc/site
anymore.constants.adoc
is directed totarget/generated-site
too (similar to release notes explained above)target/site
in a browserImplementation notes
Due to backward incompatible changes, the major version is bumped to 11.
Review kit
pom.xml
changessrc/site/antora/modules/ROOT
.github
Future work
Once this feature gets released,
pom.xml
of Log4j 2 and 3 can be trimmed significantly.