Refactoring ShingleFilter: Final Fields, Builder Pattern, and Constructor Update #13390
+277
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#13112
Made fields final and removed their respective setters. Introduced the Builder pattern to facilitate the construction of ShingleFilter instances. All previous ctors have been removed and replaced with a new one that accepts a Builder object as an input parameter (Used @IgnoreRandomChains to pass the test for now).
Since ctors were removed, an entry in MIGRATE.md is necessary, as Elasticsearch relies on this class, according to a GitHub search.
If the Builder pattern is not preferred, we could discard this approach and consider using chaining constructors instead.