Replace List<Integer> by IntArrayList and List<Long> by LongArrayList. #13406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
reviewed
May 23, 2024
| @@ -349,7 +350,7 @@ public boolean incrementToken() throws IOException { | |||
| * The last node in the alt path didn't arrive to remove this reference. | |||
| */ | |||
| assert inputNodes.get(inputFrom).tokens.isEmpty() : "about to remove non empty edge"; | |||
| outSrc.inputNodes.remove(Integer.valueOf(inputFrom)); | |||
| outSrc.inputNodes.remove(inputFrom); | |||
There was a problem hiding this comment.
I wonder if it makes sense to rename this early to "removeElement", in the spirit of changes coming to HPPC?
There was a problem hiding this comment.
Good catch!
We discussed that name in HPPC after I wrote this line and I forgot to change here. Thanks.
bruno-roustant
added a commit
that referenced
this pull request
May 27, 2024
jpountz
added a commit
to jpountz/lucene
that referenced
this pull request
May 29, 2024
Pull request apache#13406 inadvertly broke Lucene's handling of tragic exceptions by stopping after the first `DocValuesProducer` whose `close()` calls throws an exception, instead of keeping calling `close()` on further producers in the list. This moves back to the previous behavior. Closes apache#13434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IntArrayList and LongArrayList to the HPPC fork.
Use them to replace usages of List of Integer or Long.
No functional changes, only optimization for less auto-boxing and more compact structures.
Also, no public API changes.