-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a github workflow that checks common (and less common) gradle tasks when gradle version is changed #13456
Conversation
This is a follow up to #13453 - perhaps it'll make life a bit easier. |
I think that this is good. Would it run on all CI jobs, or you somehow opt-in? Running with I just merged the gradle wrapper update to main and branch_9x, so maybe sync up this PR branch to ensure that all is still good. :-) |
There is a filtering restriction - it'll run on PRs and pushes to these two branches and when the commit matches path specs. I think this restricts it reasonably well.
Yes, I think so. The run-nightly-smoketester.yml workflow uses this explicit variable to test against 22-ea. There are probably more tasks/ paths to cover. This is just a PoC and a start. |
…_JAVA_HOME as one of the variants.
Let me close this PR so that it doesn't rerun all the checks while I'm trying to figure it out locally. |
matrix: | ||
os: [ ubuntu-latest ] | ||
java-version: [ '22' ] | ||
uses-alt-java: [ true, false ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the configuration matrix switch that is used to control whether the build runs with a separate RUNTIME_JAVA_HOME or without it.
java-version: ${{ matrix.java-version }} | ||
|
||
- name: Set up RUNTIME_JAVA_HOME variable | ||
if: ${{ matrix.uses-alt-java }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're running with the "uses-alt-java" switch, we set up an "alternative" java distribution under /tmp and use it to execute the same set of gradle tasks.
I think this is ready and works reasonably well - it caught #13458 already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @dweiss LGTM (and thanks for catching and fixing the issue I caused by updating the wrapper)
…ks when gradle version is changed (#13456)
This is mostly an automated sanity check that common (and less common) tasks work after an upgrade. This is what the output looks like:
https://github.com/dweiss/lucene/actions/runs/9389691271