LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautamworah96
changed the title
gautamworah96
changed the title
gautamworah96
force-pushed
the
LUCENE-9956
branch
from
c81df3e to
46300cf
Compare
gsmiller
reviewed
May 14, 2021
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
…ery building time, add tests for it
gsmiller
reviewed
May 19, 2021
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
gsmiller
reviewed
May 25, 2021
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
.. and need to be rebuilt. Rebuild only those dimensions when the user calls getDrillDownQueries
gsmiller
reviewed
May 28, 2021
There was a problem hiding this comment.
Thanks @gautamworah96! I like your approach with the Set. I left a few comments but nothing too major.
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
Outdated
Show resolved
Hide resolved
|
Looks great. Thanks @gautamworah96! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be great if users could access the baseQuery of a DrillDownQuery. I think this can be useful for folks who want to access/test the clauses of a BooleanQuery (for example) after they've already wrapped it into a DrillDownQuery.
Currently the Query getBaseQuery() method is package private by default.
Based on comments from Greg Miller in the JIRA ticket, I decided to expose getDrillDownQueries as well
Solution
Change the method signature to public
Tests
Not added
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.