Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EdgeNGramTokenizer.DEFAULT_MAX_NGRAM_SIZE to be practical #13814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update EdgeNGramTokenizer.DEFAULT_MAX_NGRAM_SIZE to be practical #13814

wants to merge 2 commits into from
+4 −4

Conversation

YeonghyeonKO
Copy link

@YeonghyeonKO YeonghyeonKO commented Sep 20, 2024 •
edited
Loading

issue : #13802

  • Many libraries(git code: Elasticsearch, OpenSearch) based on Lucene use NGramTokenizer.DEFAULT_MAX_NGRAM_SIZE(=2) instead of EdgeNGramTokenizer's(=1) when configuring an EdgeNGramTokenizer.
  • By the above reason, it's NOT practical to keep sticking DEFAULT_MAX_NGRAM_SIZE of EdgeNGramTokenizer to be 1 so this PR changes it to be 2.
  • If it's necessary to explain this change, I'll add/change explanations by documentation.

@YeonghyeonKO YeonghyeonKO mentioned this pull request Sep 24, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YeonghyeonKO