CHANGES/MIGRATE entries for KnnVectorValues API change #13833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
approved these changes
Sep 30, 2024
|
Thanks for reviewing! ordToDoc and copy were moved from RandomAccessVectorValues; consumers will mostly just need to replace uses of that class with KnnVectorValues. As for getEncoding, yeah since it's new, there's no migration step as such related to that. I suppose it's conceivable that someone may have implemented their own subclass of Byte or FloatVectorValues and will now need to comply with the new contract, but that seems extremely expert and I don't think we'd need to cover it here? |
msokolov
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.