Revert "Ensure Panama float vector distance impls inlinable " #14041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f08f3d.
|
Thanks @rmuir |
ChrisHegarty
approved these changes
Dec 4, 2024
|
I will backport from 10.x too, and open followup issue to figure it out. Would definitely love for us to consider taking a step back and making nightly easier to debug here, maybe we can safely add and separately, test changes on AMD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14031
Reverting because of query results in nightly benchmark. Let's figure out separately what is happening. We may need to test on AMD cpu (i have some, and so does AWS).