Lucene.Net.Store.NativeFSLockFactory: Added FEATURE_SUPPORTEDOSPLATFO…

…RMATTRIBUTE so we don't have an #ifdef hard coded to a specific target framework. This fixes the CA1416 warning after targeting net8.0, and will make future targeting simpler.
apache · Oct 22, 2024 · 6844a51 · 6844a51
1 parent c013e23
commit 6844a51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -31,6 +31,7 @@
 
     <DefineConstants>$(DefineConstants);FEATURE_RANDOM_NEXTINT64_NEXTSINGLE</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_SPANFORMATTABLE</DefineConstants>
+    <DefineConstants>$(DefineConstants);FEATURE_SUPPORTEDOSPLATFORMATTRIBUTE</DefineConstants>
 
   </PropertyGroup>
 

diff --git a/src/Lucene.Net/Store/NativeFSLockFactory.cs b/src/Lucene.Net/Store/NativeFSLockFactory.cs
@@ -4,6 +4,7 @@
 using System.IO;
 using System.Collections.Generic;
 using Lucene.Net.Support.Threading;
+using System.Runtime.Versioning;
 
 namespace Lucene.Net.Store
 {
@@ -625,7 +626,7 @@ public override string ToString()
     }
 
     // Uses FileStream locking of file pages.
-#if NET6_0
+#if FEATURE_SUPPORTEDOSPLATFORMATTRIBUTE
     [System.Runtime.Versioning.SupportedOSPlatform("windows")]
 #endif
     internal class NativeFSLock : Lock
@@ -832,4 +833,4 @@ public static void Lock(this FileStream stream, long position, long length)
         }
     }
 #endif
-}
+}