Fixes 4 failing tests in .NET Framework/x86 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…numerable<T> for deferred execution
…n .NET Framework because of float comparison failures on x86 in Release mode. Fixes TestSearchAfter::TestQueries(), TestTopDocsMerge::TestSort_1(), TestTopDocsMerge::TestSort_2().
…tions on .NET Framework because of float comparison failures on x86 in Release mode. Fixes TestTokenLengthOpt().
…ept() method on .NET Framework because of float comparison failures on x86 in Release mode. Fixes TestTokenLengthOpt().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tests that are failing due to floating point precision issues on x86 when optimized. Disabling optimizations on specific methods fixes the following tests:
Lucene.Net.Sandbox.TestSlowFuzzyQuery::TestTokenLengthOpt()Lucene.Net.Search.TestSearchAfter::TestQueries()Lucene.Net.Search.TestTopDocsMerge::TestSort_1()Lucene.Net.Search.TestTopDocsMerge::TestSort_2()as recorded in #269.