BUG: Lucene.Net.Index.TestDuelingCodecs::TestEquals() (fixes #545) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e out any logic problems that were introduced by rearranging the statements
…e out any logic problems that were introduced by rearranging the statements
…ullable dictionary value
…(): Fixed issue with inverted logic on RunAutomaton.IsAccept() call that was causing random failures. Added a nightly regression test. (fixes apache#545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545.
There was a missing
!inLucene.Net.Codecs.BlockTreeTermsReader.IntersectEnum.Frame::Load()that was inverting the logic.This PR also re-ports
SimpleTextFieldsReaderandSimpleTextFieldsWriterto rule out logic bugs that may have been introduced by rearranging the statements and renaming all of the variables.Also removed an unnecessary nullable from a dictionary in
MockAnalyzer.