Skip to content

Commit

Permalink
[MARTIFACT-71] warn => info
Browse files Browse the repository at this point in the history
  • Loading branch information
hboutemy committed Oct 13, 2024
1 parent c81edae commit 310f43a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.

invoker.goals=artifact:check-buildplan
invoker.goals=artifact:check-buildplan -Ddiagnose
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@

def buildLog = new File(basedir, 'build.log').text

// https://issues.apache.org/jira/browse/MARTIFACT-24 & MARTIFACT-53
assert buildLog.contains('[WARNING] <project.build.outputTimestamp> property is inherited, it should be defined in pom.xml')
// https://issues.apache.org/jira/browse/MARTIFACT-24 & MARTIFACT-53 & MARTIFACT-71
assert buildLog.contains('[INFO] <project.build.outputTimestamp> property (= 2022-12-11T20:07:23Z) is inherited, you can override in pom.xml')
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ static boolean hasBadOutputTimestamp(
+ (effective.equals(outputTimestamp) ? "" : (" => " + effective)));
}

// check if timestamp defined in a project from reactor: warn if it is not the case
// check if timestamp defined in a project from reactor: info if it is not the case
boolean parentInReactor = false;
MavenProject reactorParent = project;
while (reactorProjects.contains(reactorParent.getParent())) {
Expand All @@ -240,8 +240,8 @@ static boolean hasBadOutputTimestamp(
}
String prop = reactorParent.getOriginalModel().getProperties().getProperty("project.build.outputTimestamp");
if (prop == null) {
log.warn("<project.build.outputTimestamp> property is inherited"
+ (parentInReactor ? " from outside the reactor" : "") + ", it should be defined in "
log.info("<project.build.outputTimestamp> property (= " + outputTimestamp + ") is inherited"
+ (parentInReactor ? " from outside the reactor" : "") + ", you can override in "
+ (parentInReactor ? "parent POM from reactor " + reactorParent.getFile() : "pom.xml"));
return false;
}
Expand Down

0 comments on commit 310f43a

Please sign in to comment.