Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSKINS-201] Replace deprecated DecorationModel#getGoogleAnalyticsAccountId() with custom value #42

Merged
merged 2 commits into from
Jan 4, 2023
Merged

[MSKINS-201] Replace deprecated DecorationModel#getGoogleAnalyticsAccountId() with custom value #42

merged 2 commits into from
Jan 4, 2023

Conversation

michael-o
Copy link
Member

@michael-o michael-o commented Jan 1, 2023 •
edited
Loading

This closes #42

@michael-o michael-o changed the title Mskins 201 [MSKINS-201] Replace deprecated DecorationModel#getGoogleAnalyticsAccountId() with custom value Jan 1, 2023
@michael-o
Copy link
Member Author

Requires #41

@michael-o michael-o mentioned this pull request Jan 1, 2023
Merged
@michael-o michael-o requested a review from hboutemy January 1, 2023 20:06
hboutemy
hboutemy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in f727e54 Jan 4, 2023
@asfgit asfgit merged commit f727e54 into master Jan 4, 2023
@michael-o michael-o deleted the MSKINS-201 branch January 4, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy hboutemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-o @hboutemy @asfgit