Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSKINS-237] Rework skin for new site model #56

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

michael-o
Copy link
Member

No description provided.

@michael-o michael-o requested a review from hboutemy October 1, 2023 15:59
@asfgit asfgit force-pushed the site-model-rework branch 3 times, most recently from 4bc31ac to 6e13bf7 Compare October 3, 2023 12:06
src/it/mskins-28/src/site/site.xml Outdated Show resolved Hide resolved
@michael-o michael-o requested a review from hboutemy October 4, 2023 11:15
asfgit pushed a commit that referenced this pull request Oct 6, 2023
@asfgit asfgit force-pushed the site-model-rework branch from 6e13bf7 to 6ba62a7 Compare October 6, 2023 09:14
@michael-o michael-o marked this pull request as ready for review October 6, 2023 09:15
@asfgit asfgit force-pushed the site-model-rework branch from 6ba62a7 to c1a6cf8 Compare October 6, 2023 09:18
@michael-o
Copy link
Member Author

@hboutemy Please have a look again.

Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your hard work

@asfgit asfgit closed this in c1a6cf8 Oct 8, 2023
@asfgit asfgit merged commit c1a6cf8 into master Oct 8, 2023
@michael-o michael-o deleted the site-model-rework branch October 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants