Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINSTALL-186] Use proper repositorySystemSession #49

Conversation

rbioteau
Copy link
Contributor

@rbioteau rbioteau commented Nov 25, 2022

When looking for existing files in the local repository, use the proper repositorySystemSession.

Current behavior ignore the localRepositoryPath parameter when checking for file existence and lead to false positive.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MINSTALL-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MINSTALL-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

When looking for existing files in the local repository, use the proper
`repositorySystemSession`.

Current behavior ignore the `localRepositoryPath` parameter when
checking for file existence and lead to false positive.
@rbioteau rbioteau force-pushed the fix/MINSTALL-186_use_proper_repositorySystemSession branch from 6b45e0b to eb96c20 Compare November 25, 2022 13:59
@slawekjaranowski slawekjaranowski merged commit 4cbbc08 into apache:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants