Add warning in strange case #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The least we can do is compare two language: one of known 'pom' type and other of project artifact: if both equal, and jar plugin is "aware" it creates JAR that is "java" language, emit a warning.
This comment was marked as outdated.
This comment was marked as outdated.
| .getArtifactHandler(getProject().getPackaging()) | ||
| .getLanguage())) { | ||
| getLog().warn( | ||
| "The project packaging language is NOT 'java'; this is most probably not what you want"); |
There was a problem hiding this comment.
What do you think to add a packaging name ... like:
The project packaging <packaging> language ...
slawekjaranowski
approved these changes
Jun 9, 2024
|
Groovy, Kotlin? |
Do Groovy or Kotlin use a custom packaging? |
I have no clue, was just hinting whether the restricition is complete. |
|
ok, m-jar-p is not the best place to check it ... the same will be with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The least we can do: check is "language" of current project packaging is "java" or not (all jar-like outputs are using language="java", only pom and bom packaging uses language="none"), and emit a WARN to user to reconsider.