-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MJAVADOC-682] Reactor builds fail when multiple modules with same gr… #253
Conversation
…oupId:artifactId, but different versions This closes #253
5f08be8
to
a861bae
Compare
I have created integration tests for MJAVADOC-682: 2f291d4 Should I create a separate pull request, or you can merge this commit into your MJAVADOC-682 branch? Thank you,
|
I will intergrate from here: https://github.com/ao-apps/maven-javadoc-plugin/tree/MJAVADOC-682 |
Should I change the commit message to begin with "[MJAVADOC-682]"? |
No, I will squash anyway and give you attributions, of course. |
…oupId:artifactId, but different versions Co-authored-by: AO Industries, Inc <support@aoindustries.com> This closes #253
CI is rolling... |
I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files. |
…oupId:artifactId, but different versions Co-authored-by: AO Industries, Inc <support@aoindustries.com> This closes #253
Modified... |
I went ahead and confirmed the provided integration tests for MJAVADOC-682 do, in fact, reproduce the originally reported issue: The build succeeds on 3.0.1 and fails on 3.6.2 as expected. |
for inclusion in version 3.6.3.
…oupId:artifactId, but different versions
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MJAVADOC-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-its
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.