Maven Daemon CLIng #1158
Maven Daemon CLIng #1158
Conversation
Dropped the MavenCLI mutilated copy, using CLIng. WIP
|
Pretty much same results as for me locally: |
|
Locally |
|
With apache/maven#1776 |
|
Slowly but mvnd is giving up 😄 With apache/maven#1779 |
But was added in old CLI :(
|
Score |
|
At least two ITs are NPE-ing due unusual IT project layout @gnodet is tinkering about those. Personally, I'd not change ITs, Maven is too rigid IMHO. |
|
Maven changes merged, so this PR now uses master. CI confirms my local results, failed ITs with reason:
|
|
MNG-8288 fixed, last issue is MNG-8293. Basically this PR is "good", it is Maven core that has issues with ITs. |
|
Removed use of mrm plugin, test repeats, and fixed classpath by excluding maven logging provider (that is excluded from final distro as well). |
daemon/src/main/java/org/apache/maven/cli/DaemonMavenParser.java
Outdated
Show resolved
Hide resolved
| .groupId(parts[0]) | ||
| .artifactId(parts[1]) | ||
| .version(parts[2]) | ||
| .build(); |
There was a problem hiding this comment.
This needs to be extended, as extensions.xml may have more options, like classloading?
There was a problem hiding this comment.
This is for another PR, as this PR did not alter anything in this area
|
Mac intel had "java.net.ConnectException: HTTP connect timed out" |
Log should not be dumped to sysout unconditionally, makes logs unmanageable.
Dropped the MavenCLI mutilated copy, using CLIng.
This PR also removes test repeat and use of mrm plugin, just to simplify the build. Also fixes classpath by excluding maven logging provider (that is excluded from final distro as well) as mvnd provides its own provider.