Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document to use Guice constructor injection #345

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Update document to use Guice constructor injection #345

merged 2 commits into from
Dec 23, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 13, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 13, 2024 19:44
@elharo elharo requested a review from hboutemy December 13, 2024 19:44
slachiewicz
slachiewicz reviewed Dec 14, 2024
View reviewed changes
maven-plugin-tools-annotations/src/site/apt/index.apt

private final MojoExecution mojoExecution;

public MyMojo(MyComponent component, MavenSession session, MavenProject project, MojoExecution mojoExecution) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inject annotation missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@elharo elharo changed the title Update documnent to use Guice constructor injection Update document to use Guice constructor injection Dec 15, 2024
slawekjaranowski
slawekjaranowski approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be also updated for 3.x branch?

@elharo
Copy link
Contributor Author

elharo commented Dec 23, 2024

Should be also updated for 3.x branch?

Do we publish both?

@elharo elharo merged commit 4a5fe6a into master Dec 23, 2024
57 checks passed
@elharo elharo deleted the elharo-patch-2 branch December 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz left review comments

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@hboutemy hboutemy Awaiting requested review from hboutemy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @slawekjaranowski @slachiewicz