-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPIR-455] - add support for multi-release JARs. #70
Conversation
Regarding the entry count, it seems to be a bug in the shared-jar library. The root version entries are not saved anywhere. However an easy workaround (until the next shared-jar version release with a fix) would be to take the difference between the total count and each version. In this case is 37-(9+9)=19 in the root. The total of 37 can be in the first row (showing file attributes). WDYT? |
That sounds quite reasonable! Can you create an issue with the library first, then tacke in MPIR and then add a comment around the dep entry in the POM that we depend on issue and code needs to be changed? That would be a way forward until then. |
...ain/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
Show resolved
Hide resolved
...ain/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
Show resolved
Hide resolved
...ain/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with that. We can still improve when the shared lib has been improved.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MPIR-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MPIR-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.