Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1096] Many cleanups and updates #132

Merged
merged 1 commit into from
May 31, 2022

Conversation

nielsbasjes
Copy link
Contributor

MRELEASE-1096

There is a lot of room for improvement.

  • Some dependencies have inconsistent versions (slf4j)
  • Some dependencies in the integration tests are ancient and some have todo points about workarounds for which the solution has been release ages ago.
  • Junit 3 should be at least Junit 4.

@nielsbasjes
Copy link
Contributor Author

@michael-o As requested the separate cleanups.
Some dependencies have been updated, not all.

maven-release-manager/pom.xml Outdated Show resolved Hide resolved
maven-release-plugin/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@nielsbasjes nielsbasjes force-pushed the MRELEASE-1096-CleanupsUpdates branch from 6a742f8 to a32681c Compare May 27, 2022 20:26
@michael-o
Copy link
Member

@cstamas Can you have a look at those two open questions?

@nielsbasjes nielsbasjes force-pushed the MRELEASE-1096-CleanupsUpdates branch from a32681c to 2b1de97 Compare May 31, 2022 15:37
@@ -193,7 +193,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
<version>1.3.8</version>
<version>@plexusMavenPluginVersion@</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This likely needs to be rewritten in the future with Sisu and annotations.

* Upgrade to SLF4J 1.7.36
* Upgrade to JUnit 4.13.2

In ITs:
* Upgrade to Maven Compiler Plugin 3.10.1
* Upgrade to Maven Invoker Plugin 3.2.2
* Upgrade to Plexus Maven Plugin 1.3.8
* Upgrade to Plexus Component Metadata 1.7.1

This closes apache#132
@michael-o michael-o force-pushed the MRELEASE-1096-CleanupsUpdates branch from 2b1de97 to 281b680 Compare May 31, 2022 18:57
@michael-o michael-o self-requested a review May 31, 2022 18:57
@asfgit asfgit closed this in 281b680 May 31, 2022
@asfgit asfgit merged commit 281b680 into apache:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants