-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRELEASE-1096] Many cleanups and updates #132
Merged
asfgit
merged 1 commit into
apache:master
from
nielsbasjes:MRELEASE-1096-CleanupsUpdates
May 31, 2022
Merged
[MRELEASE-1096] Many cleanups and updates #132
asfgit
merged 1 commit into
apache:master
from
nielsbasjes:MRELEASE-1096-CleanupsUpdates
May 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@michael-o As requested the separate cleanups. |
7 tasks
michael-o
requested changes
May 27, 2022
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml
Outdated
Show resolved
Hide resolved
nielsbasjes
force-pushed
the
MRELEASE-1096-CleanupsUpdates
branch
from
May 27, 2022 20:26
6a742f8
to
a32681c
Compare
@cstamas Can you have a look at those two open questions? |
nielsbasjes
force-pushed
the
MRELEASE-1096-CleanupsUpdates
branch
from
May 31, 2022 15:37
a32681c
to
2b1de97
Compare
michael-o
reviewed
May 31, 2022
@@ -193,7 +193,7 @@ | |||
<plugin> | |||
<groupId>org.codehaus.plexus</groupId> | |||
<artifactId>plexus-maven-plugin</artifactId> | |||
<version>1.3.8</version> | |||
<version>@plexusMavenPluginVersion@</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This likely needs to be rewritten in the future with Sisu and annotations.
* Upgrade to SLF4J 1.7.36 * Upgrade to JUnit 4.13.2 In ITs: * Upgrade to Maven Compiler Plugin 3.10.1 * Upgrade to Maven Invoker Plugin 3.2.2 * Upgrade to Plexus Maven Plugin 1.3.8 * Upgrade to Plexus Component Metadata 1.7.1 This closes apache#132
michael-o
force-pushed
the
MRELEASE-1096-CleanupsUpdates
branch
from
May 31, 2022 18:57
2b1de97
to
281b680
Compare
michael-o
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRELEASE-1096
There is a lot of room for improvement.