[MRELEASE-1154] Never fail for unresolvable version expressions #230
Conversation
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java
Outdated
Show resolved
Hide resolved
Refactor code and add tests
kwin
changed the title
| } else { | ||
| // artifact not related to current release | ||
| // the expression used to define the version of this artifact may be inherited | ||
| logInfo( |
There was a problem hiding this comment.
maybe logWarn is actually better here.
There was a problem hiding this comment.
We need to take into account the fact that modelVersion 4.1.0 will allow users to only define the version in the root parent, all other versions will be inferred. I would not want tons of warnings when using such setup.
If this is a supported use case, I don't see why a warning would be legit.
|
Alternative to #229. |
|
Any more feedback? I would like to merge this in order to fix the underlying regression. |
Will pick up tomorrow |
There was a problem hiding this comment.
Hard to tell, honestly. The CI friendy part is implemented half-heartedly and it breaks stuff. I, personally, don't understand the fuzz and the artificial complexity around the CI friendly stuff, but it should be complete or none AND not break other stuff.
@slawekjaranowski @cstamas @gnodet Any opinion?
While I prefer #229, I can live with this one.
kwin
deleted the
feature/improve-exception-message-for-unresolvable-version-expressions
branch
expressions
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MRELEASE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-itsto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.