Skip to content

Commit

Permalink
[MSCMPUB-57] Upgrade misc deps
Browse files Browse the repository at this point in the history
maven-shared-utils to 3.3.4
commons-land to 3.12.0
maven-release-manager to 3.0.0-M7
org.apache.maven.scm:* to 2.0.0-M3
  • Loading branch information
slachiewicz committed Mar 4, 2023
1 parent ef21a97 commit c8b0849
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 11 deletions.
30 changes: 26 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ under the License.
</distributionManagement>

<properties>
<scmVersion>1.11.2</scmVersion>
<scmVersion>2.0.0-M3</scmVersion>
<mavenVersion>3.2.5</mavenVersion>
<javaVersion>8</javaVersion>

Expand All @@ -79,7 +79,23 @@ under the License.
<dependency>
<groupId>org.apache.maven.release</groupId>
<artifactId>maven-release-manager</artifactId>
<version>2.5.3</version>
<version>3.0.0-M7</version>
</dependency>
<!-- remove with maven-release-manager upgrade -->
<dependency>
<groupId>org.apache.sshd</groupId>
<artifactId>sshd-core</artifactId>
<version>2.9.2</version>
</dependency>
<dependency>
<groupId>org.apache.sshd</groupId>
<artifactId>sshd-common</artifactId>
<version>2.9.2</version>
</dependency>
<dependency>
<groupId>org.apache.sshd</groupId>
<artifactId>sshd-osgi</artifactId>
<version>2.9.2</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
Expand All @@ -104,12 +120,18 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
<version>3.3.3</version>
<version>3.3.4</version>
</dependency>
<!-- remove with maven-shared-utils upgrade -->
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.11.0</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.1</version>
<version>3.12.0</version>
</dependency>
<dependency>
<groupId>org.apache.maven.scm</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import org.apache.maven.settings.crypto.SettingsDecryptionRequest;
import org.apache.maven.settings.crypto.SettingsDecryptionResult;
import org.apache.maven.shared.release.config.ReleaseDescriptor;
import org.apache.maven.shared.release.config.ReleaseDescriptorBuilder;
import org.apache.maven.shared.release.scm.ScmRepositoryConfigurator;
import org.apache.maven.shared.utils.logging.MessageUtils;

Expand Down Expand Up @@ -318,8 +319,8 @@ private ReleaseDescriptor setupScm() throws ScmRepositoryException, NoSuchScmPro
logInfo("Performing a LOCAL checkout from " + scmUrl);
}

ReleaseDescriptor releaseDescriptor = new ReleaseDescriptor();
releaseDescriptor.setInteractive(settings.isInteractiveMode());
ReleaseDescriptorBuilder descriptorBuilder = new ReleaseDescriptorBuilder();
descriptorBuilder.setInteractive(settings.isInteractiveMode());

if (username == null || password == null) {
for (Server server : settings.getServers()) {
Expand All @@ -345,12 +346,12 @@ private ReleaseDescriptor setupScm() throws ScmRepositoryException, NoSuchScmPro
}
}

releaseDescriptor.setScmPassword(password);
releaseDescriptor.setScmUsername(username);
descriptorBuilder.setScmPassword(password);
descriptorBuilder.setScmUsername(username);

releaseDescriptor.setWorkingDirectory(basedir.getAbsolutePath());
releaseDescriptor.setLocalCheckout(localCheckout);
releaseDescriptor.setScmSourceUrl(pubScmUrl);
descriptorBuilder.setWorkingDirectory(basedir.getAbsolutePath());
descriptorBuilder.setLocalCheckout(localCheckout);
descriptorBuilder.setScmSourceUrl(pubScmUrl);

if (providerImplementations != null) {
for (Map.Entry<String, String> providerEntry : providerImplementations.entrySet()) {
Expand All @@ -361,6 +362,7 @@ private ReleaseDescriptor setupScm() throws ScmRepositoryException, NoSuchScmPro
}
}

ReleaseDescriptor releaseDescriptor = descriptorBuilder.build();
scmRepository = scmRepositoryConfigurator.getConfiguredRepository(releaseDescriptor, settings);

scmProvider = scmRepositoryConfigurator.getRepositoryProvider(scmRepository);
Expand Down

0 comments on commit c8b0849

Please sign in to comment.