Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly strip quotes in GitStatusConsumer #26

Merged
merged 2 commits into from
Apr 6, 2016
Merged

Correctly strip quotes in GitStatusConsumer #26

merged 2 commits into from
Apr 6, 2016

Commits on Jan 2, 2015

  1. Correctly strip quotes in GitStatusConsumer 

    Before this, `GitStatusConsumer.resolvePath()` and
`GitStatusConsumer.resolveURI()` got into trouble with
files that include spaces.

To reproduce failure condition (in a git repo):

    echo "I'll fail" > "some nice file"
    git add "some nice file"
    git status --porcelain

The output of the `git status` is:

    A  "some nice file"

This causes at least
[JENKINS-24686](https://issues.jenkins-ci.org/browse/JENKINS-24686)
downstream.
    @sralmai
    sralmai committed Jan 2, 2015
    Configuration menu
    Copy the full SHA
    f9e39a0 View commit details
    Browse the repository at this point in the history

  2. Fix style

    @sralmai
    sralmai committed Jan 2, 2015
    Configuration menu
    Copy the full SHA
    9080d85 View commit details
    Browse the repository at this point in the history