Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor bad smell UnnecessaryToStringCall #186

Merged
merged 3 commits into from
May 17, 2023
Merged

refactor: refactor bad smell UnnecessaryToStringCall #186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff5122
Refactor bad smells:
MartinWitt May 3, 2023
14d26d0
Update MinijarFilter.java
MartinWitt May 3, 2023
9640fdc
fix spotless
MartinWitt May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,14 +262,13 @@ private ClazzpathUnit addDependencyToClasspath(Clazzpath cp, Artifact dependency
log.warn(dependency.getFile()
+ " could not be unpacked/read for minimization; dependency is probably malformed.");
IOException ioe = new IOException(
"Dependency " + dependency.toString() + " in file " + dependency.getFile()
"Dependency " + dependency + " in file " + dependency.getFile()
+ " could not be unpacked. File is probably corrupt",
e);
throw ioe;
} catch (ArrayIndexOutOfBoundsException | IllegalArgumentException e) {
// trap ArrayIndexOutOfBoundsExceptions caused by malformed dependency classes (MSHADE-107)
log.warn(dependency.toString()
+ " could not be analyzed for minimization; dependency is probably malformed.");
log.warn(dependency + " could not be analyzed for minimization; dependency is probably malformed.");
}

return clazzpathUnit;
Expand Down