Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double "up to" when rendered #216

Closed
wants to merge 1 commit into from
Closed

Avoid double "up to" when rendered #216

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 21, 2024

@elharo elharo requested a review from hboutemy February 21, 2024 12:26
@hboutemy
Copy link
Member

hboutemy commented Feb 22, 2024

honestly, https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-prerequisites.html is a Maven-dev-internal report without real expectations from end users

the important question is: is it better for maven-shade-plugin end-users experience to update in order to make https://maven.apache.org/plugins/maven-shade-plugin/plugin-info.html easier to understand?

BTW at dist-tool level, this PR on maven-shade-plugin will lead to "up to from 1.0 to 1.4" instead of "up to up to 1.4" in the dist tool report, because dist-tool just fetches plugin-info.html from plugins
hacking the dist tool happens on https://github.com/apache/maven-dist-tool, and yes, we should probably update the code to better handle changes in the way we see this requirements history rendering: https://issues.apache.org/jira/browse/MPLUGIN-510

@hboutemy
Copy link
Member

on the dist-tool aspect, solved by removing the field in apache/maven-dist-tool@160b1fb

report https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-prerequisites.html now only says "up to requires Maven 2.2.1 + JDK 5" which is sufficient: no real need for the earliest plugin versions that had these requirements

@elharo elharo closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants