fix a number of small warnings and formatting issues #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibor17
reviewed
Feb 24, 2020
| , text | ||
| , is( expectedContent ) ); | ||
| try (Scanner base = new Scanner( expandedFile ); | ||
| Scanner scanner = base.useDelimiter( "\n" ) ) |
There was a problem hiding this comment.
Having two local variables with the same reference is not necessary. It is the flow design:
https://docs.oracle.com/javase/7/docs/api/java/util/Scanner.html#useDelimiter(java.util.regex.Pattern)
There was a problem hiding this comment.
This was an interesting corner case I'd not encountered before and it took a while to figure out. It cures a warning about failure to close the first scanner in try-with-resources block. Though looking at it now I see another way to approach this.
Tibor17
reviewed
Feb 24, 2020
Tibor17
reviewed
Feb 24, 2020
src/test/java/org/apache/maven/shared/utils/cli/CommandLineUtilsTest.java
Show resolved
Hide resolved
elharo
commented
Mar 21, 2020
|
which branch at https://builds.apache.org/job/maven-box/job/maven-shared-utils/ ? |
|
… On Sat, Mar 21, 2020 at 10:54 AM Robert Scholte ***@***.***> wrote:
which branch at
https://builds.apache.org/job/maven-box/job/maven-shared-utils/ ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVP2EQ5QGW4MRUUEVFQV3RITILBANCNFSM4KZ34H3A>
.
--
Elliotte Rusty Harold
elharo@macfaq.com
|
rfscholte
reviewed
Mar 21, 2020
elharo
commented
Mar 23, 2020
michael-o
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tibor17