-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHARED-1196] Bump maven-shared-components from 37 to 39 #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All license headers in Java files are duplicated.
Ick. I blame spotless, which is not so spotless. Let me see if I can fix that. |
OK, I think the duplicate licenses are removed. I am very much not a fan of spotless at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ready for another review. This PR involves a lot more churn than I like, but it appears to be necessary to keep up with the Maven parent POM which is now enforcing a different code style than we used to use.
Looks like a few broken Javadoc cross-ref links trip only one of our CIs. Fixing...
|
This required a lot of automatic reformatting and a little manual reformatting to make spotless happy