-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6380] Option -Dstyle.color=always doesn't force color output #67
Conversation
I need to release jansi before merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?
I will have a look at this combined with other Maven issues in a few days. |
I've pushed commits to leverage today's changes to Jansi. @slachiewicz I'm not sure to understand your question, could you rephrase please ? |
Rebased on top of #69 |
The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see apache/maven@151e349 |
Running through jenkins on branch gnodet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JAnsi looks released. Can this be merged?
pom.xml
Outdated
@@ -70,7 +70,7 @@ | |||
<dependency> | |||
<groupId>org.fusesource.jansi</groupId> | |||
<artifactId>jansi</artifactId> | |||
<version>2.0.1</version> | |||
<version>2.2.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 2.3.1 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but the 2.3.0/2.3.1 only brings two additional native methods specifically for mvnd
and no other changes, so there is no real benefit either.
@MartinKanters jansi is a dependency both maven-shared and core maven, so it needs to be upgraded in both. In addition, MNG-6380 is resolved with the commits in this PR and not simply the upgrade of jansi. |
…uences are stripped or let through
Rebased and squashed. |
jenkins passed. |
No description provided.