[SUREFIRE-2010] Parameterized Selection Does not Work

[DaGeRe]

This pull request provides the example project for an integration test, that checks whether selectors are able to select parameterized tests, e.g. package.TestClazz#method[1], where 1 is the index of the test.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[Tibor17]

Hi @DaGeRe ,

The JIRA is not well suited to read code patches. We can discuss the code even if the CI would fail.

[Tibor17]

OutputValidator validator = is useless.

[DaGeRe]

Yes, this was only for starting. The plan is to run it once with all tests and than with a selector.

Now, I've added

TestFile surefireReportsFile = validator.getSurefireReportsFile( "de.dagere.peass.ExampleTestJUnit4.txt" );
surefireReportsFile.assertContainsText( "Tests run: 2" );

which unfortunately fails.

[Tibor17]

Due to this parent POM specifies <forkMode>never</forkMode> it is a problem for all ITs and the tests won't run in a fork mode. There are two alternatives how to solve this. Override the parameter to the default value <forkMode>once</forkMode> or use <version>${surefire.version}</version>.

[DaGeRe]

Thanks, I've added the forkMode.

[Tibor17]

It would be nice to adjust the code style in these files well.
Pls configure your IDE, here is instructions and code style XML for your IDEs:
https://maven.apache.org/developers/conventions/code.html#intellij-idea

[DaGeRe]

Thank, I've imported the style and hopefully reformatted it correctly.

[Tibor17]

@DaGeRe
If we want to test our documentation, we should use the pattern which would filter only some executions of parameterized test. Example mvn test -Dtest=*ExampleTestJUnit4#testMethod[5:*] and the IT allows you to assert lines in the logs and XML reports too. https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html

[DaGeRe]

Thanks for the hints. I adapted the code, but is there any part of the maven launcher which allows to pass something like -Dtest=MySelector, or do I have to call it myself? Just adding it as goal ends in

[ERROR] Unknown lifecycle phase "test -Dtest=ExampleTestJUnit4". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version
>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, g
enerate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-cle
an, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]

I can debug this with -Dmaven.surefire.debug=true, but that does not help to create the process correctly.

[chalmagr]

Thanks for the hints. I adapted the code, but is there any part of the maven launcher which allows to pass something like -Dtest=MySelector, or do I have to call it myself? Just adding it as goal ends in

[ERROR] Unknown lifecycle phase "test -Dtest=ExampleTestJUnit4". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version
>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, g
enerate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-cle
an, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]

I can debug this with -Dmaven.surefire.debug=true, but that does not help to create the process correctly.

Make sure to use org.apache.maven.surefire.its.fixture.SurefireLauncher#sysProp to add the option and not the execute method execute("test -Dtest=...")

[andpab]

The best way to pass something like -Dtest=MySelector to the SurefireLauncher is to use SurefireLauncher#setTestToRun like this:

unpack( "surefire-2010-parameterized-selection-does-not-work" )
    .setTestToRun( "MySelector" )
    .executeTest();

[AlexShmydov]

Hi all! Any news about this problem?

Is still actual on maven 3.1.2 and Junit 5.10.1

[AlexShmydov]

Guys, can somebody to help?
I am talking about junit-team/junit5#2743 and https://issues.apache.org/jira/browse/SUREFIRE-1724
How we can run single invocation of test?