[MWRAPPER-103] Apply recommended workaround #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure is thie import module needed for other use of Get-FileHash as well? |
jorsol
reviewed
Apr 17, 2024
| @@ -160,6 +160,7 @@ FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapp | |||
| ) | |||
| IF NOT %WRAPPER_SHA_256_SUM%=="" ( | |||
| powershell -Command "&{"^ | |||
| "Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash"^ | |||
There was a problem hiding this comment.
I assume that a ; is needed at the end of Get-FileHash.
There was a problem hiding this comment.
Hm, no idea, but Google found me this: https://poshcode.gitbook.io/powershell-practice-and-style/style-guide/code-layout-and-formatting#avoid-using-semicolons-as-line-terminators
There was a problem hiding this comment.
even if it is to avoid, will add to be consistent with existing PS code....
Import the thing just before trying to use it?
cstamas
requested review from
hboutemy,
michael-o,
bmarwell and
slawekjaranowski
michael-o
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Marcono1234 on JIRA issue recommended, added workaround just before the use of
Get-FileHashcall.https://issues.apache.org/jira/browse/MWRAPPER-103