-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWRAPPER-104] add prettier config for shell #84
Conversation
You might want to talk about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok for me
By the way issue will be appreciated for it. |
5b3d44a
to
bb0d151
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply new format to make a build pass 😄
bb0d151
to
c6dd23a
Compare
@slachiewicz @slawekjaranowski rebased and added a commit which applies the prettier config |
@bmarwell thanks ... I did forgot it 😄 I see that we should first update parent to the latest in order to build under JDK 21 |
Was about to say the same. Yup. There are a couple more PRs we should put into the next release. |
f549226
to
cba755d
Compare
Signed-off-by: Benjamin Marwell <bmarwell@apache.org>
fdeed11
to
732c014
Compare
This is an alternate proposal for running a bash linter. This time it integrates with spotless (and you can use spotlesss:apply). The other approach is using shellcheckk (#82) which is a little more known and does not require npm modules, but does not integrate with spotless as nicely.
Signed-off-by: Benjamin Marwell bmarwell@apache.org
Fixes MWRAPPER-104
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MWRAPPER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.