[MNG-8023] New method + javadoc on Project #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new method that returns POM and project Artifact in sensible manner (so install or deploy and other does not need to figure out anything). Also, javadoc the class. --- https://issues.apache.org/jira/browse/MNG-8023
michael-o
requested changes
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
michael-o
requested changes
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
michael-o
requested changes
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jan 19, 2024
| @Nonnull | ||
| String getPackaging(); | ||
|
|
||
| /** | ||
| * Returns the project POM artifact, that is the artifact of the POM of this project. Every project have POM | ||
| * artifact, while the existence of backing POM file is NOT a requirement (i.e. for some transient projects). |
There was a problem hiding this comment.
Returns the project POM artifact, which is the artifact of the POM of this project. Every project have a POM
artifact, even if the existence of backing POM file is NOT a requirement (i.e. for some transient projects).
There was a problem hiding this comment.
While we're at it, we're missing a paragraph to explain the behaviour in case a ModelParser is used (for example to parse a POM in a different syntax/language). I'll need to have a look at that.
There was a problem hiding this comment.
K, will wait for your evaluation...
gnodet
reviewed
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jan 19, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jan 20, 2024
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultProject.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jan 20, 2024
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultProject.java
Outdated
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new method that returns POM and project Artifact in sensible manner (so install or deploy and other does not need to figure out anything).
Also, javadoc the class.
https://issues.apache.org/jira/browse/MNG-8023