Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8232] Introduce ModelTransformer #1702

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[MNG-8232] Introduce ModelTransformer #1702

merged 1 commit into from
Sep 12, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Sep 7, 2024 •
edited
Loading

@gnodet gnodet added this to the 4.0.0-beta-5 milestone Sep 8, 2024
@gnodet gnodet mentioned this pull request Sep 9, 2024
Merged
@gnodet gnodet requested a review from cstamas September 9, 2024 14:51
@cstamas
Copy link
Member

cstamas commented Sep 11, 2024

This PR contains DI stuff as well....

cstamas
cstamas reviewed Sep 11, 2024
View reviewed changes
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelTransformer.java
@Experimental
@Consumer
@Named
public interface ModelTransformer extends SpiService {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnodet
[MNG-8232] Introduce ModelTransformer
e368db2 
# Conflicts:
#	api/maven-api-spi/src/main/resources/META-INF/maven/org.apache.maven.api.di.Inject
@gnodet gnodet merged commit 625b456 into apache:master Sep 12, 2024
13 checks passed
@gnodet gnodet deleted the MNG-8232 branch September 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-beta-5
Development

Successfully merging this pull request may close these issues.
2 participants
@gnodet @cstamas