Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8362] Adding some missing config properties #1861

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 30, 2024

To have them listed in generated docs.


https://issues.apache.org/jira/browse/MNG-8362

@cstamas cstamas requested a review from gnodet October 30, 2024 13:41
@cstamas cstamas self-assigned this Oct 30, 2024
@cstamas cstamas marked this pull request as ready for review October 30, 2024 14:34
@cstamas cstamas added this to the 4.0.0-beta-6 milestone Oct 30, 2024
* @since 3.0.0
*/
@Config(type = "java.lang.Boolean", defaultValue = "false")
public static final String MAVEN_VERSION_RESOLVER_NO_CACHE = "aether.versionResolver.noCache";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make it start with maven. instead of aether. to be consistent with all other properties ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.
This component is in maven, but implements Resolver API (as Resolver is "incomplete"), but yes, I agree, this is a Maven implementation detail, not resolver.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@cstamas cstamas merged commit dfd5ec5 into apache:master Nov 5, 2024
13 checks passed
@cstamas cstamas deleted the MNG-8362 branch November 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants