[MNG-8386] Pull out executor #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mixup, as "executor" unlike "invoker" does not expect all (in fact it expects nothing) on classpath. So introduce new dependency less (minimal ones) maven-executor that implements two simple executors (forked and embedded) and leave maven-cli for invoker implementations.
Now that the issue is figured out...
I was sitting on a horse in opposite direction. Context close needs to happen with all registered stuff, ONLY the container (and looked up stuff) needs to be "carried over".
it makes AnsiTerminal install counter offset -1
As they fail on Windows due junit being unable to delete the log file mvn3 produces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another CLIng cleanup.
Changes:
https://issues.apache.org/jira/browse/MNG-8386