-
Notifications
You must be signed in to change notification settings - Fork 512
METRON-2312 solr scripts fixup #1558
base: master
Are you sure you want to change the base?
METRON-2312 solr scripts fixup #1558
Conversation
FYI, Apache Metron does not depend directly on HDP Search (that's a vendor-specific support thing) - we actually use the OSS version of Solr by default. We should verify that Apache Solr works by default first using the provided install instructions in the dev env, and then check that we can still accommodate other 3rd party packaging. To wit, I'm not 100% sure if the zookeeper "/solr" endpoint is universal or not, so this check might need to be adapted a bit. |
Quote from jira
|
Thanks for adding that. Just a heads up, it's probably worth adding a link and a note on the PR when putting that level of detail in the Jira, at least for now. There has been some scattered discussion about getting better descriptions in Jiras, but for the most part we rely almost exclusively on the gitbot copying PR contents into the Jira activity history currently. Most folks, myself included, typically look primarily at the PR description when reviewing PRs. |
Will link to Jira in future. |
retest this please |
Contributor Comments
Issue being fixed:
source /etc/defaults/metron
$METRON_HOME/bin/add-collection bro
The command returns
and the SOLR collection is not created.
The readme in Metron-solr-common notes that the scripts do not work outside of Ambari by default if SOLR is using chroot zookeeper addressing and that you need to manually tweak $ZOOKEEPER environment variable to include the chrooted Zookeeper addresses that SOLR is storing its information at.
The fix:
a. If zkcli did not return a SOLR Cloud node, return 1.
b. if zkcli did not return a SOLR Cloud node, and $ZOOKEEPER does not end in '/solr', make a suggestion to the user that it should.
Testing:
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.