-
Notifications
You must be signed in to change notification settings - Fork 509
METRON-480: Kibana 4.5+ Requires http.cors.enabled set to false on ES #288
Conversation
I have verified this fix on a 12-node openstack cluster. Generated a fresh set of RPMs with the fix provided in this pull request, and setup the cluster afresh. After the installation completes, the Kibana dashboard comes up fine. |
</property> | ||
<property> | ||
<name>http_cors_enabled</name> | ||
<value>"false"</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the quotes don't get removed in the .j2 files, can we move the quotes into those, then just leave this as a plain string without quotes? I'm not sure if using the quotes is required or not, but if they are then users might not remember to add them.
If we do want to change that, given that path_data does this even in the Github snippet, I'm sure this occurs more frequently and we may want to create a separate task for cleaning all of them up in one fell swoop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinleet Do you think this needs addressed in this PR? If so, we can hold-off until @dlyle65535 has a chance to respond. Otherwise, respond with a +1 and we can merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I'm fine with it being merged as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to have the quotes, otherwise Ambari will treat it as a boolean which will be written as False in elasticsearch.yml and Elasticsearch doesn't recognize that as False for this parameter only.
Please don't make them all the same in a clean-up pr, it will break things that work.
Was this intended to fix the following error thrown by Kibana when it tries to talk to Elasticsearch?
|
Ah, chased down the JIRA. Looks like it is. |
To fix this using Ambari on an existing ES cluster would I just go to... |
No, it defaults to false, so no user action is required. |
Darn. Can't edit on the phone. Are you seeing this on an existing cluster? A default ES instance should default to false. |
I am seeing this on a cluster that I deployed with the mpack from 'master'. ES is happy and excited to play. When I hit up Kibana I get this error.
In researching the error, I ran across this on Github/Kibana which refers to the Now I'm confused though because in this PR you set a |
If I manually login to each ES master and remove the Of course, once Ambari gets involved it undoes my manual edit. I have not yet figured out how to 'unset' this through Ambari yet. |
+1 This PR did fix the issue that I was seeing. Tested on a live cluster. |
Tested with simulated Docker cluster.
Installed Elasticsearch and Kibana services together post-install and verified Kibana could initialize.