-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Flaky test_random.test_exponential_generator @ Python2: MKLDNN-CPU #9843
Comments
It seems this problem is related to #9856 |
As shown in the log, the chi-square value is above the 0.05 threshold (indicates the check has passed) once in the 5 runs, i.e, 20% success rate. Currently we force the success rate to be 25% (https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/test_utils.py#L1848), we could lower it to 10% to fix the test. |
That might fix the test, but could we risk masking a problem that way? I'm afraid I'm unfamiliar with the topic, so would you mind explaining how an actual failure would look like and how we could select the best threshold? |
@marcoabreu A wrongly implemented random number generator would typically have success_rate = 0, i.e, producing p < 0.05 for all the 5 runs. However, since this tests the randomness, it's really tricky to set the threshold and my previous design is to force the success rate to be at least 25%. |
This test also fails constantly with a special seed.
|
Should I revise the code to use a smaller threshold? |
@marcoabreu the success rate has been lowered. do we know if this test is still causing us problems? |
Haven't seen any problems recently. Thanks for following up! |
kk ran this test 500x as well and didn't see a problem
|
Found a failure of this test on the CI pipeline on Windows-CPU. Details of failure captured here : http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwindows-cpu/detail/PR-13678/30/pipeline |
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/395/pipeline
The text was updated successfully, but these errors were encountered: