Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Test] smaller success rate for test random #9927

Merged

Conversation

sxjscience
Copy link
Member

Description

Set the success_rate to 15%. Should fix #9856 and #9843

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Set the success_rate to 15%

Comments

  • Randomness tests are really difficult. There always exist specific seeds to break the test. This PR will not solve the problem, but will make the test fail less often.

@sxjscience sxjscience requested a review from szha as a code owner February 28, 2018 20:22
@piiswrong piiswrong merged commit d87468e into apache:master Feb 28, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_random.test_gamma_generator
2 participants